-
Notifications
You must be signed in to change notification settings - Fork 498
Compile test plugins as MODULE instead of STATIC #2897
Conversation
we still need to test with ARM, but just looking at our other supported platforms, I believe this has fixed the tests on Ubuntu amd64, but the macOS tests are still broken. apparently
we don't need to block this PR on macOS; if it fixes Ubuntu amd64 and ARM, we can add some comments to #800 about this and follow up later |
Interesting. I agree on following on #800. |
@j-rivero I just merged with |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I started another job but it didn't finish
|
it's looking better; the arm build succeeded, though there are more test failures than normal and the console output suggests a runtime problem
the windows build is failing though
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the iteration and fixing the changelog!
Revert part of #2753 which change the compilation of plugins to STATIC.
Should fix #2883 in the gazebo11 branch. Needs to be tested on ARM.